mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 46887: Added the HTTP GET authorization action to the documentation.
Date Tue, 14 Jun 2016 13:13:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46887/#review137495
-----------------------------------------------------------




docs/authorization.md (line 140)
<https://reviews.apache.org/r/46887/#comment202632>

    Could we
    a) check that the HTTP HELP text is correct for all these endpoints (i.e, mentions AUTHORIZATION)
    b) mention here that the HTTP endpoint HELP contains information about this?
    
    s/supports/covers (as it does not allow individual endpoints, it is a all or nothing decision)



docs/authorization.md (line 601)
<https://reviews.apache.org/r/46887/#comment202636>

    .. endpoints (due to the `permissive = false`).



docs/upgrades.md (line 75)
<https://reviews.apache.org/r/46887/#comment202637>

    can you double check that label is still available (I believe I saw/wrote another patch
using that label).



docs/upgrades.md (line 217)
<https://reviews.apache.org/r/46887/#comment202638>

    enables required authorization for the following endpoint.



docs/upgrades.md (line 224)
<https://reviews.apache.org/r/46887/#comment202639>

    Add something along the lines: Be careful when using this together with ACLs and permissive
= false.


- Joerg Schad


On June 14, 2016, 11:46 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46887/
> -----------------------------------------------------------
> 
> (Updated June 14, 2016, 11:46 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Joerg Schad, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the HTTP GET authorization action to the documentation.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 0df0d4ccd76379ede6492e595999711e5462f79b 
>   docs/authorization.md dcf2160424771c513579063911cc14792f464821 
>   docs/upgrades.md afc76f7a0e74042bd095b925f8119bfa5daa489c 
> 
> Diff: https://reviews.apache.org/r/46887/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message