mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 48387: Delay before initiating a connection with master.
Date Tue, 14 Jun 2016 14:40:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48387/#review137507
-----------------------------------------------------------



This is looking much better. 

Can you include both `flags.hpp/flags.cpp` in `src/Makefile.am`? This would fix the ReviewBot
build failures.


src/scheduler/constants.hpp (line 27)
<https://reviews.apache.org/r/48387/#comment202655>

    s/connection/connecting with the master



src/scheduler/scheduler.cpp (line 319)
<https://reviews.apache.org/r/48387/#comment202652>

    As per my review comment in an earlier version of the patch, let's have the signature
of this method as:
    
    ```cpp
    void connect(const UUID& _connectionId);
    ```
    
    And you can invoke this as:
    
    ```cpp
    process::delay(delay, self(), &MesosProcess::connect, connectionId.get());
    ```



src/scheduler/scheduler.cpp (line 477)
<https://reviews.apache.org/r/48387/#comment202649>

    Bring this assignment down to L488 i.e. just before `Duration delay` where it is used.



src/scheduler/scheduler.cpp (lines 481 - 487)
<https://reviews.apache.org/r/48387/#comment202647>

    hmm .. Why do you need to load the flags again here? You already did so on line L154,
no?



src/scheduler/scheduler.cpp (line 496)
<https://reviews.apache.org/r/48387/#comment202648>

    Nit: new line before
    
    We typically have a new line after a statement spanning multiple lines for readability.


- Anand Mazumdar


On June 13, 2016, 11:20 p.m., Jose Guilherme Vanz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48387/
> -----------------------------------------------------------
> 
> (Updated June 13, 2016, 11:20 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5359
>     https://issues.apache.org/jira/browse/MESOS-5359
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The scheduler library has been updated to wait a little deley before
> initiate a connection with the master. The maximum amount of time waited
> by the scheduler is defined by a flag: CONNECTION_DELAY_MAX. After
> the master has been detected the scheduler picks a random delay that
> can be between 0 and the CONNECTION_DELAY_MAX value. MESOS-5359
> 
> 
> Diffs
> -----
> 
>   src/scheduler/constants.hpp PRE-CREATION 
>   src/scheduler/flags.hpp PRE-CREATION 
>   src/scheduler/scheduler.cpp c79837c93e7329dbfa22e4288b44237f33408ba9 
> 
> Diff: https://reviews.apache.org/r/48387/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jose Guilherme Vanz
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message