mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Megha Sharma <megha.hitesh.ka...@gmail.com>
Subject Re: Review Request 47972: Updated rmdir to optionally continue deletion on error.
Date Tue, 14 Jun 2016 17:08:49 GMT


> On June 8, 2016, 5:22 a.m., Jiang Yan Xu wrote:
> > 3rdparty/stout/include/stout/os/windows/rmdir.hpp, line 120
> > <https://reviews.apache.org/r/47972/diff/2/?file=1400004#file1400004line120>
> >
> >     This looks to be over 80 chars too, let's fix all of them by running mesos-style.py.

Actually most of the lines over 80 characters including this one didn't get flagged when I
ran mesos-style.py


- Megha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47972/#review136482
-----------------------------------------------------------


On June 8, 2016, 8:42 p.m., Megha Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47972/
> -----------------------------------------------------------
> 
> (Updated June 8, 2016, 8:42 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Jiang Yan
Xu.
> 
> 
> Bugs: MESOS-5196
>     https://issues.apache.org/jira/browse/MESOS-5196
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updates made to rmdir to prevent early exit in the event of error.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/posix/rmdir.hpp a6d3b578762d5c570542b0497578c330820b821a

>   3rdparty/stout/include/stout/os/windows/rmdir.hpp 772b86dd111d28aefbeeba5f829ffa377fd12efb

>   3rdparty/stout/tests/os/rmdir_tests.cpp a11bfc9f9e6cbb05f3e9ce0ea48297b8f88fe53f 
> 
> Diff: https://reviews.apache.org/r/47972/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> Tested with option --gtest_also_run_disabled_tests.
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message