mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48595: Exposed the logging process `PID` in libprocess.
Date Tue, 14 Jun 2016 17:58:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48595/#review137556
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/include/process/logging.hpp (line 42)
<https://reviews.apache.org/r/48595/#comment202698>

    s/setLevel/set_level/
    
    stout and libprocess use snake case.


- Vinod Kone


On June 12, 2016, 6:02 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48595/
> -----------------------------------------------------------
> 
> (Updated June 12, 2016, 6:02 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5486
>     https://issues.apache.org/jira/browse/MESOS-5486
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Exposed the logging process `PID` in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/logging.hpp 651cb3736705124bec9e4366c0e7adc5d5b488f0

>   3rdparty/libprocess/include/process/process.hpp 646059e2740a32dd9c483dfa56c71dc46727862c

>   3rdparty/libprocess/src/logging.cpp 222449b904268a47868be374bf8202aafe6516fe 
>   3rdparty/libprocess/src/process.cpp b4cdba6b0cd4f8f373f37118cd2e9d4955f2425a 
> 
> Diff: https://reviews.apache.org/r/48595/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message