mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 48363: Moved 'isolators/cgroups/devices/gpus' to 'isolators/gpu'.
Date Tue, 14 Jun 2016 21:12:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48363/#review137578
-----------------------------------------------------------


Ship it!





src/slave/containerizer/mesos/containerizer.cpp (lines 59 - 63)
<https://reviews.apache.org/r/48363/#comment202758>

    Looks like this should be alongside isolator includes?


- Benjamin Mahler


On June 11, 2016, 3:04 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48363/
> -----------------------------------------------------------
> 
> (Updated June 11, 2016, 3:04 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5551
>     https://issues.apache.org/jira/browse/MESOS-5551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved 'isolators/cgroups/devices/gpus' to 'isolators/gpu'.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am b656702d918e747cbd4b3d8f2c4257f61c83b385 
>   src/slave/containerizer/mesos/containerizer.cpp 92c9898fb41ca0ffbda05e53b595b05c96f4f596

>   src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.hpp 181a2aad97da9ee0f6ffa42cdba9c93dc0077ff7

>   src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp d7557a0c338e8c0e51461b2326600c03f89c2e8b

> 
> Diff: https://reviews.apache.org/r/48363/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message