mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.
Date Tue, 14 Jun 2016 21:35:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48596/#review137585
-----------------------------------------------------------




src/tests/api_tests.cpp (line 101)
<https://reviews.apache.org/r/48596/#comment202768>

    no response doesn't necessarily mean OK(), it could be Accepted() as well. that's why
i suggested earlier to not have this helper at all but rather inline it.



src/tests/api_tests.cpp (line 225)
<https://reviews.apache.org/r/48596/#comment202769>

    s/first,/first;/



src/tests/api_tests.cpp (line 245)
<https://reviews.apache.org/r/48596/#comment202770>

    Delete this comment.



src/tests/api_tests.cpp (line 250)
<https://reviews.apache.org/r/48596/#comment202773>

    Put this comment above Clock::pause()



src/tests/api_tests.cpp (line 254)
<https://reviews.apache.org/r/48596/#comment202774>

    s/revert/reverted/


- Vinod Kone


On June 12, 2016, 6:02 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48596/
> -----------------------------------------------------------
> 
> (Updated June 12, 2016, 6:02 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5486
>     https://issues.apache.org/jira/browse/MESOS-5486
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented v1::master::Call::SET_LOGGING_LEVEL.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp cd089cf6afd654b07608548f441a0e225df6425e 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48596/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message