mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48600: Used `DurationInfo` as `timeout` type in `GetMetrics` operation APIs.
Date Tue, 14 Jun 2016 21:38:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48600/#review137588
-----------------------------------------------------------




include/mesos/master/master.proto (line 88)
<https://reviews.apache.org/r/48600/#comment202775>

    Can you add some comments here about this call and its parameters. Please don't forget
to do it for all calls in this review chain.


- Vinod Kone


On June 12, 2016, 6:03 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48600/
> -----------------------------------------------------------
> 
> (Updated June 12, 2016, 6:03 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay Guo, and
Vinod Kone.
> 
> 
> Bugs: MESOS-5484
>     https://issues.apache.org/jira/browse/MESOS-5484
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `DurationInfo` as `timeout` type in `GetMetrics` operation APIs.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto PRE-CREATION 
>   include/mesos/slave/slave.proto PRE-CREATION 
>   include/mesos/v1/agent.proto b9b1680afec4e73c31a9e0aeb74153d129c54ee6 
>   include/mesos/v1/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8 
> 
> Diff: https://reviews.apache.org/r/48600/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message