mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.
Date Wed, 15 Jun 2016 04:35:11 GMT


> On June 13, 2016, 10:07 p.m., Vinod Kone wrote:
> > src/master/http.cpp, lines 596-632
> > <https://reviews.apache.org/r/48585/diff/5/?file=1416175#file1416175line596>
> >
> >     s/mesos:://
> 
> Anand Mazumdar wrote:
>     I guess @haosdent had to add them due to there being an already existing `master`
namespace in our code. The compiler would have barfed otherwise due to it not being able to
find a `Call` class in the existing `master` namespace. Hence, it _had_ to be fully qualified.
>     
>     Since, we _only_ use the unversioned protobuf internally in our code, we should just
do `using mesos::master::Call` and then just use `Call::TYPE` for referring to it. Sound good?
> 
> Vinod Kone wrote:
>     I see. Qualified mesos::master::Call seems fine then. `using mesos::master::Call`
 might be weird because we also have scheduler::Call in this file.
> 
> haosdent huang wrote:
>     Oh, yes, as @anandmazumdar said, we need add mesos:: otherwise compiler return errors.
@vinodkone Could I drop these issues?

yup!


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48585/#review137403
-----------------------------------------------------------


On June 12, 2016, 6:01 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48585/
> -----------------------------------------------------------
> 
> (Updated June 12, 2016, 6:01 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5593
>     https://issues.apache.org/jira/browse/MESOS-5593
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Devolved v1 operator protos to unversioned operator protos in Master.
> 
> 
> Diffs
> -----
> 
>   src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 
>   src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
>   src/master/http.cpp cd089cf6afd654b07608548f441a0e225df6425e 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
>   src/master/validation.hpp e1271bbaebaac52a078eedfdc2299c7c6f4474f8 
>   src/master/validation.cpp 7b9c2281b2ab1295211f0dd385cd77947fbd63be 
> 
> Diff: https://reviews.apache.org/r/48585/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message