mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 48495: Added missing 'get_weights' actions to authorization.md.
Date Wed, 15 Jun 2016 06:37:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48495/#review137670
-----------------------------------------------------------




docs/authorization.md (line 130)
<https://reviews.apache.org/r/48495/#comment202854>

    s/updated/viewed/
    s/Updating weights/Get weights for roles/
    
    Also, let's add a link to [weights](weights.md)



docs/authorization.md (lines 132 - 134)
<https://reviews.apache.org/r/48495/#comment202855>

    These Subject descriptions (column 2) are wrong. The subject in this ACL is not the "Unix
user...", but the HTTP user.
    And we're talking about the LocalAuthorizer here, so the Object (column 3) should have
nothing to do with a WhateverInfo, but instead should be the "Operating system user whose
whatever can be accessed."


- Adam B


On June 14, 2016, 6:21 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48495/
> -----------------------------------------------------------
> 
> (Updated June 14, 2016, 6:21 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-5583
>     https://issues.apache.org/jira/browse/MESOS-5583
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Additionally fixed typo(s). Note that 'get_endpoints' which
> is also missing here will be added with 46887.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md dcf2160424771c513579063911cc14792f464821 
> 
> Diff: https://reviews.apache.org/r/48495/diff/
> 
> 
> Testing
> -------
> 
> viewed via docker website container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message