mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 48601: Exposed metrics information via `process::metrics::snapshot`.
Date Wed, 15 Jun 2016 15:41:27 GMT


> On June 14, 2016, 10:59 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/src/metrics/metrics.cpp, lines 262-292
> > <https://reviews.apache.org/r/48601/diff/2/?file=1416205#file1416205line262>
> >
> >     This induces a performance regression to /metrics/snapshot REST endpoint!
> >     
> >     See https://reviews.apache.org/r/48046/ for inspiration on how to refactor methods
that use JSON::ObjectWriter.

Hi, @vinodkone Thank you very much to point out this. I take a look https://reviews.apache.org/r/48400/
and I think could return a hashmap here so that we don't need return `Future<Tuple<hashmap<string,
Future<double>>, hashmap<string, Option<Statistics<double>>>>>`.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48601/#review137604
-----------------------------------------------------------


On June 15, 2016, 2:30 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48601/
> -----------------------------------------------------------
> 
> (Updated June 15, 2016, 2:30 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay Guo, and
Vinod Kone.
> 
> 
> Bugs: MESOS-5484
>     https://issues.apache.org/jira/browse/MESOS-5484
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Exposed metrics information via `process::metrics::snapshot`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/metrics/metrics.hpp 25e8fcaeb9c71eaa43096165745e79c8198c139a

>   3rdparty/libprocess/src/metrics/metrics.cpp be03406c58439b7ab7c1ba12c19dd9f30aff109e

> 
> Diff: https://reviews.apache.org/r/48601/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message