mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 48687: Enhanced log message if the absolute path does not exist.
Date Wed, 15 Jun 2016 23:57:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48687/#review137888
-----------------------------------------------------------


Fix it, then Ship it!




Could you this nit in `recover()` and `_recover()` in docker/volume/isolator.cpp as well.


src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 360 - 361)
<https://reviews.apache.org/r/48687/#comment203104>

    just some nits:
    
    would you mind having the space to upper line?
    e.g.,
    
    ```
              return Failure("Absolute container path '" + target + "' "
                             "does not exist");```



src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 418)
<https://reviews.apache.org/r/48687/#comment203106>

    ditto.


- Gilbert Song


On June 14, 2016, 5:34 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48687/
> -----------------------------------------------------------
> 
> (Updated June 14, 2016, 5:34 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5611
>     https://issues.apache.org/jira/browse/MESOS-5611
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enhanced log message if the absolute path does not exist.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 8cebfebbd9bf3f616f3cd305889f3372aca5e3f3

>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 35213ce8f9d0e81fdd2da15c7a2cee1c779f3555

> 
> Diff: https://reviews.apache.org/r/48687/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050
--command="sleep 100000" --name=test --volumes=/root/test/volume4.json
> WARNING: Logging before InitGoogleLogging() is written to STDERR
> W0614 09:21:25.100939 28209 parse.hpp:115] Specifying an absolute filename to read a
command line option out of without using 'file:// is deprecated and will be removed in a future
release. Simply adding 'file://' to the beginning of the path should eliminate this warning.
> I0614 09:21:25.104532 28209 scheduler.cpp:187] Version: 1.0.0
> I0614 09:21:25.106834 28231 scheduler.cpp:471] New master detected at master@192.168.56.12:5050
> Subscribed with ID '57cda92a-b703-435a-94f0-28e88746f8b5-0000'
> Submitted task 'test' to agent '57cda92a-b703-435a-94f0-28e88746f8b5-S0'
> Received status update TASK_FAILED for task 'test'
>   message: 'Failed to launch container: Absolute container path '/tmp/abc' does not exist;
Container destroyed while preparing isolators'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message