mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 44498: Forbid the executor to inherit from slave environment.
Date Sat, 18 Jun 2016 04:31:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44498/#review138385
-----------------------------------------------------------




src/slave/containerizer/containerizer.cpp 
<https://reviews.apache.org/r/44498/#comment203562>

    Can we include a default $PATH? I tested docker:
    ```
    [jie@core-dev build]$ sudo docker run --entrypoint env alpine
    PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
    HOSTNAME=85e069a25704
    HOME=/root
    ```
    
    Let's use the above as the default just to be safe. Otherwise, some isolation script might
break (e.g., `mount` for docker volume isolator needs to be in $PATH). Please add a NOTE about
that.
    
    If `PATH` is already set in `executor_environment_variables`, skip this step.


- Jie Yu


On June 14, 2016, 8:03 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44498/
> -----------------------------------------------------------
> 
> (Updated June 14, 2016, 8:03 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Forbid the executor to inherit from slave environment.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 7612d39d88dc6c0229b5def9697a97ab387f6ef1 
>   src/slave/containerizer/containerizer.hpp ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf

>   src/slave/containerizer/containerizer.cpp faa0c789dda8a6f36fdb6217b0bae270b6b8f2e2

>   src/slave/containerizer/docker.hpp 311dca23ac17fb533866aba1de2b81d750bbe6df 
>   src/slave/containerizer/docker.cpp 63efbe6f45958d44d60fe4a7fea816f5fb0457b2 
>   src/slave/flags.cpp 7b0e347772646c177c1e18334633a71bc6cedb85 
> 
> Diff: https://reviews.apache.org/r/44498/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message