mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Deshna Jain <deshna...@gmail.com>
Subject Re: Review Request 48613: Added validation logic for UUID's.
Date Sat, 18 Jun 2016 07:58:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48613/
-----------------------------------------------------------

(Updated June 18, 2016, 7:58 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Fix up - Removed function `validateFromBytes` and modified `fromBytes` to return `Try<UUID>`
along with checking valid uuid string.


Bugs: MESOS-5224
    https://issues.apache.org/jira/browse/MESOS-5224


Repository: mesos


Description
-------

This change adds a `validateFromBytes` function for validating
UUID's by checking if they are one of the supported UUID
versions.


Diffs (updated)
-----

  3rdparty/stout/include/stout/uuid.hpp cde3bdbbdcc428410c83a7724389056f7aaf63a1 
  3rdparty/stout/tests/uuid_tests.cpp 50295ad25843a3938a5a58f5ba7f082f8ffeba45 

Diff: https://reviews.apache.org/r/48613/diff/


Testing
-------

make check


Thanks,

Deshna Jain


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message