mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.
Date Sat, 18 Jun 2016 09:56:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48614/#review138394
-----------------------------------------------------------



Bad patch!

Reviews applied: [48614, 48901, 48613]

Failed command: ./support/apply-review.sh -n -r 48901

Error:
2016-06-18 09:56:56 URL:https://reviews.apache.org/r/48901/diff/raw/ [15903/15903] -> "48901.patch"
[1]
error: patch failed: src/master/master.cpp:4340
error: src/master/master.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13871/console

- Mesos ReviewBot


On June 18, 2016, 8:21 a.m., Deshna Jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48614/
> -----------------------------------------------------------
> 
> (Updated June 18, 2016, 8:21 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5224
>     https://issues.apache.org/jira/browse/MESOS-5224
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds logic to the master/agent validation helpers
> to see if the status update acknowledgments have a valid UUID
> set conforming to one of the supported versions.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 7b9c2281b2ab1295211f0dd385cd77947fbd63be 
>   src/slave/validation.cpp 189d10caf4517a1aff62b523d8eb99d9d1ca4b6a 
>   src/tests/scheduler_http_api_tests.cpp c12205f90e4f2da2c6ad7a0ea75777601eb0ef13 
> 
> Diff: https://reviews.apache.org/r/48614/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Deshna Jain
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message