mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.
Date Sat, 18 Jun 2016 17:11:09 GMT


> On June 17, 2016, 6:36 a.m., haosdent huang wrote:
> > src/internal/devolve.hpp, line 28
> > <https://reviews.apache.org/r/48268/diff/4/?file=1421267#file1421267line28>
> >
> >     Put this above
> >     ```
> >     #include <mesos/scheduler/scheduler.hpp>
> >     ```

I think the alphabectial should be `opq rst`. So

```
#include <mesos/scheduler/scheduler.hpp>

#include <mesos/quota/quota.hpp>

#include <mesos/v1/mesos.hpp>
```

should change to

```
#include <mesos/quota/quota.hpp>

#include <mesos/scheduler/scheduler.hpp>

#include <mesos/v1/mesos.hpp>
```

right?


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48268/#review138170
-----------------------------------------------------------


On June 18, 2016, 2:53 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48268/
> -----------------------------------------------------------
> 
> (Updated June 18, 2016, 2:53 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5509
>     https://issues.apache.org/jira/browse/MESOS-5509
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented SET_QUOTA Call in v1 master API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/master/master.proto 59e978fef6e0faca7dc8c25b47a79f0b5007d0a6 
>   include/mesos/v1/quota/quota.hpp PRE-CREATION 
>   src/Makefile.am a4931560f1a5b3fbe41ea181477341d3ac459b58 
>   src/internal/devolve.hpp 4a6ae681d37b3405ee81c4a58388b8d501743ebf 
>   src/master/http.cpp a6beb1721958a77886f0aa535346e2ff33bd5d04 
>   src/master/master.hpp 618d928ef1398e7397df968c7cd47acbc987d1e3 
>   src/master/quota_handler.cpp 567f1c2cc59b859227a8b48c6086ce3f8049f14d 
>   src/tests/api_tests.cpp afa5ffab8729dfc5b102968ec64c6a3bcd832dfd 
> 
> Diff: https://reviews.apache.org/r/48268/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> sudo GTEST_FILTER="*MasterAPITest.SetQuota*" make -j4 check
> 
> [==========] Running 2 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 2 tests from ContentType/MasterAPITest
> [ RUN      ] ContentType/MasterAPITest.SetQuota/0
> [       OK ] ContentType/MasterAPITest.SetQuota/0 (129 ms)
> [ RUN      ] ContentType/MasterAPITest.SetQuota/1
> [       OK ] ContentType/MasterAPITest.SetQuota/1 (98 ms)
> [----------] 2 tests from ContentType/MasterAPITest (227 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 2 tests from 1 test case ran. (236 ms total)
> [  PASSED  ] 2 tests.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message