mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Deshna Jain <deshna...@gmail.com>
Subject Re: Review Request 48901: Fixed all source files affected by the `fromBytes()` change.
Date Sat, 18 Jun 2016 21:04:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48901/
-----------------------------------------------------------

(Updated June 18, 2016, 9:04 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Fix up.


Bugs: MESOS-5224
    https://issues.apache.org/jira/browse/MESOS-5224


Repository: mesos


Description
-------

This change fixes all occurrences in the existing code
of `fromBytes()` that needed revisiting after the return
type has been changed to a `Try`.


Diffs (updated)
-----

  include/mesos/state/state.hpp f2fddee4fa803fa0572f6194e7f5f45a56254c00 
  src/examples/long_lived_executor.cpp 770aae2fcc7a11db9abab31262cf81967796bb23 
  src/examples/test_http_executor.cpp 1a04b75c885733b01c624e29f0bf8f68a9cd7346 
  src/exec/exec.cpp f78e8b66947b33d70c4d4aaf11f66de6a84389fb 
  src/launcher/executor.cpp 877b0fdbcacf92d36f85f16457c38edb204f489b 
  src/master/master.cpp 1971e9bf3875ceb117130b84533dc37873ca60df 
  src/messages/messages.cpp 9274b1b3964a52a7929c2f1e9cea55e84b7549a1 
  src/slave/slave.cpp 4bf01f2b020f5e975fb57cffcd19865d7431eac2 
  src/slave/state.cpp 04c3d42040f186507a0e484a3ee616f1b1a77ea8 
  src/slave/status_update_manager.cpp 0e9891c2e8219f901610b8ec711fd45919ae6fbe 
  src/state/in_memory.cpp c50f46dba45199ca4f3060039ad094a93a8a2e18 
  src/state/leveldb.cpp 6cd86551d88018ee6a044491f78c21a90abf83e4 
  src/state/log.cpp 2a55913c4a246ef09b73eb8205826e88c1963171 
  src/state/zookeeper.cpp 1ba700ef4a1f650cb8c5d9090bf004398f2729e0 
  src/tests/slave_recovery_tests.cpp 2238355e9459cf4598a7aa96d3c6153a2dfcaa13 

Diff: https://reviews.apache.org/r/48901/diff/


Testing
-------

make check


Thanks,

Deshna Jain


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message