mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Review Request 48913: Added a `nvml::makeDiscoverable()` call to Nvidia's NVML abstraction.
Date Sat, 18 Jun 2016 22:05:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48913/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-5550
    https://issues.apache.org/jira/browse/MESOS-5550


Repository: mesos


Description
-------

This call is not actually part of the NVMl library itself.
We provide this funtion to allow NVML to be discovered only
in cases where we actually plan to use GPUs (e.g. when the
GPU isolator is enabled).


Diffs
-----

  src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp cfb23244d0e6f6e0d94685a35826b35f3297c6fe

  src/slave/containerizer/mesos/isolators/gpu/nvml.hpp 15217407acdb6ceb6efc695580b1f441d1891daf

  src/slave/containerizer/mesos/isolators/gpu/nvml.cpp 4aea25abb5a522949b0ff9fb808c8b1a592e97ba


Diff: https://reviews.apache.org/r/48913/diff/


Testing
-------

$ make -j check; sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message