mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 48921: Added a check of namespaces in Posix launcher.
Date Mon, 20 Jun 2016 19:17:48 GMT


> On June 19, 2016, 6:57 p.m., Avinash sridharan wrote:
> > src/slave/containerizer/mesos/launcher.cpp, line 94
> > <https://reviews.apache.org/r/48921/diff/1/?file=1423504#file1423504line94>
> >
> >     Is there a valid case where we would be calling `fork` with `namespaces = `
? If not isn't checking namespaces.isSome() enough?

Unfortunately, we always pass in a `namespace` (i.e. Some). We need to change that later.
I'll add a TODO at the call site.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48921/#review138474
-----------------------------------------------------------


On June 19, 2016, 5:10 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48921/
> -----------------------------------------------------------
> 
> (Updated June 19, 2016, 5:10 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, haosdent huang, and Kapil
Arya.
> 
> 
> Bugs: MESOS-5533
>     https://issues.apache.org/jira/browse/MESOS-5533
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Posix launcher does not support namespaces. We should reject the launch
> if namespaces are desired (e.g., from isolators). The currently behavior
> of silently ignoring it will cause weird issues.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/launcher.cpp b1b323b4040fd72a7f01e60781eaf992e4ef766a

> 
> Diff: https://reviews.apache.org/r/48921/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message