mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 48963: Removed hard dependence on `libelf`.
Date Mon, 20 Jun 2016 21:03:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48963/#review138678
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On June 20, 2016, 8:52 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48963/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 8:52 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5663
>     https://issues.apache.org/jira/browse/MESOS-5663
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We recently added a hard dependency for `libelf` on Linux. This was in
> preparation for some upcoming Nvidia GPU support for injecting volumes
> into containers. Since this dependence is not actually necessary for
> the upcoming release, we decided to remove it for now, and rethink the
> best way to add it back in later (possibly as a runtime dependence
> instead of a linktime one).
> 
> For now, we just remove the one test that actually uses this
> functionality from the build (namely, `ldcache_tests.cpp`). We will
> add them back in once we know how we plan to deal with this
> dependency.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG aed56300f1090c816ab2893c20e87fd37230a9a7 
>   configure.ac 3c0cfcaf4ddbaa7bd4cba35796d8ab7e71dcd9a3 
>   docs/getting-started.md 11e1d1f65ef050d26d96a85bab58512379ea1976 
>   src/Makefile.am a4931560f1a5b3fbe41ea181477341d3ac459b58 
>   support/docker_build.sh 11799b887db2b1d11351785c1ebe81c4f4c92121 
> 
> Diff: https://reviews.apache.org/r/48963/diff/
> 
> 
> Testing
> -------
> 
> rm -rf build
> mkdir build
> cd build
> ../configure
> make -j check
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message