mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 48969: Deprecated 'taskInfo' and 'executorInfo' in isolator 'ContainerConfig'.
Date Mon, 20 Jun 2016 21:53:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48969/#review138683
-----------------------------------------------------------




include/mesos/slave/isolator.proto 
<https://reviews.apache.org/r/48969/#comment203876>

    Should I just comment out these two lines and leave a NOTE there?
    
    So that people would know protobuf field # `1` and `2` are used before and deprecated,
in case anyone uses that # again.


- Gilbert Song


On June 20, 2016, 2:50 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48969/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 2:50 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Artem Harutyunyan, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Deprecated 'taskInfo' and 'executorInfo' in isolator 'ContainerConfig'.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
>   src/slave/containerizer/mesos/containerizer.cpp 77be9506eadb7098a6ded3baf452342e5e228b6c

> 
> Diff: https://reviews.apache.org/r/48969/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message