mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48841: Add Agent protobuf message.
Date Mon, 20 Jun 2016 22:04:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48841/#review138685
-----------------------------------------------------------




include/mesos/mesos.proto (line 2020)
<https://reviews.apache.org/r/48841/#comment203877>

    This is only used by the master API. So please move this inside `GetAgents` message.



include/mesos/v1/master/master.proto 
<https://reviews.apache.org/r/48841/#comment203879>

    just add agent info here.



include/mesos/v1/mesos.proto (line 2019)
<https://reviews.apache.org/r/48841/#comment203878>

    ditto. move this to v1/master.proto.


- Vinod Kone


On June 18, 2016, 1:59 p.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48841/
> -----------------------------------------------------------
> 
> (Updated June 18, 2016, 1:59 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5491
>     https://issues.apache.org/jira/browse/mesos-5491
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch added Agent protobuf message to:
> 1. v1 message: v1/mesos.proto & v1/master/master.proto
> 2. unversioned message: mesos.proto & master/master.proto
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto fa92240e9d16fdde3d98314f9efbc1c70f9ddb88 
>   include/mesos/mesos.proto e4c5bd31cf035707036eb509336fe051119b4e78 
>   include/mesos/v1/master/master.proto 59e978fef6e0faca7dc8c25b47a79f0b5007d0a6 
>   include/mesos/v1/mesos.proto 9be22f02861f1eb89ab547d88530faf90ebee7ab 
> 
> Diff: https://reviews.apache.org/r/48841/diff/
> 
> 
> Testing
> -------
> 
> make 
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message