mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.
Date Mon, 20 Jun 2016 23:41:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48313/
-----------------------------------------------------------

(Updated June 20, 2016, 11:41 p.m.)


Review request for mesos, Neil Conway and Jiang Yan Xu.


Bugs: MESOS-5448
    https://issues.apache.org/jira/browse/MESOS-5448


Repository: mesos


Description
-------

When the agent receives CheckpointedResourcesMessage, we store the
target checkpoint on disk. On successful create and destroy of
persistent volumes as a part of handling this messages, we commit
the checkpoint on the disk, and clear the target checkpoint.

However, incase of any failure we do not commit the checkpoint to
disk, and exit the agent. When the agent restarts and there is a
target checkpoint present on disk which differs from the committed
checkpoint, we retry to sync the target and committed checkpoint.
On success, we reregister the agent with the master, but in case it
fails, we do not commit the checkpoint and the agent exists.


Diffs (updated)
-----

  src/slave/paths.hpp 339e539863c678b6ed4d4670d75c7ff4c54daa79 
  src/slave/paths.cpp 03157f93b1e703006f95ef6d0a30afae375dcdb5 
  src/slave/slave.hpp 58ff2bfac6918d989ab36b67cf6ba2f3657c8356 
  src/slave/slave.cpp 4bf01f2b020f5e975fb57cffcd19865d7431eac2 
  src/slave/state.hpp 0de2a4ee4fabaad612c4526166157b001c380bdb 
  src/slave/state.cpp 04c3d42040f186507a0e484a3ee616f1b1a77ea8 

Diff: https://reviews.apache.org/r/48313/diff/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message