mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48879: Added logic for subscribing to task added/updated events.
Date Tue, 21 Jun 2016 00:50:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48879/#review138721
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.hpp (line 396)
<https://reviews.apache.org/r/48879/#comment203909>

    can you move this inside `Subscribers` ?



src/master/master.cpp (line 7528)
<https://reviews.apache.org/r/48879/#comment203908>

    Make this LOG(INFO).


- Vinod Kone


On June 20, 2016, 11:09 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48879/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 11:09 p.m.)
> 
> 
> Review request for mesos, Vinod Kone and Zhitao Li.
> 
> 
> Bugs: MESOS-5609
>     https://issues.apache.org/jira/browse/MESOS-5609
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change sets the initial scaffolding in place allowing
> a client to subscribe to events via the '/api/vX' endpoint.
> Currently, only two events are supported i.e. `TASK_ADDED`/
> `TASK_UPDATED`.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp ccf0a4e1e6c6f004c7890cc142206f09e76a76c3 
>   src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d 
>   src/master/master.cpp 1971e9bf3875ceb117130b84533dc37873ca60df 
> 
> Diff: https://reviews.apache.org/r/48879/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message