mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 48979: Added check for `--isolation=gpu/nvidia` in order to autodiscover GPUs.
Date Tue, 21 Jun 2016 01:43:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48979/#review138734
-----------------------------------------------------------


Ship it!




- Benjamin Mahler


On June 21, 2016, 1:36 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48979/
> -----------------------------------------------------------
> 
> (Updated June 21, 2016, 1:36 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5257
>     https://issues.apache.org/jira/browse/MESOS-5257
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We add this check because we decided it makes sense to only do
> autodiscovery of GPUs when this isolator is turned on (unlike for
> CPUs, memory, and disk where autodiscovery happens by default). We
> decided to take this approach, because GPU support is still
> experimental, and is only known to work well if this isolator is
> enabled. We didn't want to start advertising GPUs in our resource
> offer and have people attempt to use them in scenarious we haven't
> considered yet. In the future we may support other use cases, but for
> now we are being cautious.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.cpp ea1473f25dbb2e6bca097592b85f801d9b376c3a

>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp e06d107f2dcdb9b470e330c8ceee66a54220d41b

> 
> Diff: https://reviews.apache.org/r/48979/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message