mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 49004: Copied network info if specified in Docker executor.
Date Tue, 21 Jun 2016 05:00:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49004/#review138769
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


src/docker/executor.cpp (line 192)
<https://reviews.apache.org/r/49004/#comment203964>

    s/NetworkInfo/`NetworkInfo`



src/docker/executor.cpp (line 193)
<https://reviews.apache.org/r/49004/#comment203965>

    s/ContainerInfo/`ContainerInfo`



src/docker/executor.cpp (line 194)
<https://reviews.apache.org/r/49004/#comment203966>

    s/NetworkInfo/`NetworkInfo`
    s/in containerizer/ in the `DockerContainerizer`


- Avinash sridharan


On June 21, 2016, 4:52 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49004/
> -----------------------------------------------------------
> 
> (Updated June 21, 2016, 4:52 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Copied network info if specified in Docker executor.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp a1fd5b1034ece415cc5805e12fc55816385ec71d 
> 
> Diff: https://reviews.apache.org/r/49004/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message