mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <>
Subject Review Request 49000: Reordered function definitions in master actor HTTP handlers.
Date Tue, 21 Jun 2016 05:05:03 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Abhishek Dasgupta, zhou xing, Jay Guo, haosdent huang, and Vinod

Repository: mesos


This change performs the following function definition reordering:

- It groups pre v1 API/v1 Master API handlers nearby for better
readability. There were already some functions already doing this.
- For some handlers that use a helper function, it defines them
_before_ the HELP string variable. This means that now the
HELP strings immediatly precede the handler implementation
which is more intuitive to the reader.


  src/master/http.cpp 3a53ef74f3e80e832804a21cebe0fc9e405420cb 



make check (would be doing a similar change for the agent)


Anand Mazumdar

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message