mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 48751: Implement GetState response for master API.
Date Tue, 21 Jun 2016 05:11:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48751/#review138770
-----------------------------------------------------------



Bad patch!

Reviews applied: [48751]

Failed command: ./support/apply-review.sh -n -r 48751

Error:
2016-06-21 05:05:43 URL:https://reviews.apache.org/r/48751/diff/raw/ [20562/20562] -> "48751.patch"
[1]
error: include/mesos/v1/master.proto: does not exist in index
error: patch failed: include/mesos/v1/mesos.proto:1961
error: include/mesos/v1/mesos.proto: patch does not apply
error: patch failed: src/internal/evolve.hpp:56
error: src/internal/evolve.hpp: patch does not apply
error: patch failed: src/master/http.cpp:617
error: src/master/http.cpp: patch does not apply
error: patch failed: src/tests/api_tests.cpp:36
error: src/tests/api_tests.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13916/console

- Mesos ReviewBot


On June 15, 2016, 8:52 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48751/
> -----------------------------------------------------------
> 
> (Updated June 15, 2016, 8:52 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5489
>     https://issues.apache.org/jira/browse/MESOS-5489
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implement GetState response for master API, which should be functional equivalent (but
not necessarily fully compatible on json with `/state` endpoint).
> 
> The response protobuf message and new function `_getState` will be reused for generating
snapshot for `Subscribe` call in next patch.
> 
> Also copied `Task` message to V1 API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8 
>   include/mesos/v1/mesos.proto 39967fa09d2774d564f3df28277edea8ebcfb50d 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
>   src/master/http.cpp db625f0d656f207a89fcc14b18ae2fc31d30e673 
>   src/master/master.hpp a0944ddccd3a4b33458cd2489bb5fcdbbdc55720 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48751/diff/
> 
> 
> Testing
> -------
> 
> New test in MasterAPITest.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message