mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.
Date Tue, 21 Jun 2016 09:44:58 GMT


> On March 14, 2016, 2:23 a.m., haosdent huang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/info.hpp, line 55
> > <https://reviews.apache.org/r/44762/diff/1/?file=1296906#file1296906line55>
> >
> >     Another problem here is could not avoid different threads to modify a same `CgroupsIsolatorInfo`
object in a easy way.

Can you please clarify this multi-thread issue with more details? Why do we need to modify
a `CgroupsIsolatorInfo` object in multiple threads?


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44762/#review123321
-----------------------------------------------------------


On March 14, 2016, 1:50 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44762/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 1:50 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4697
>     https://issues.apache.org/jira/browse/MESOS-4697
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add CgroupsIsolator. This is only used for discussion.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
>   src/Makefile.am f2a592dba3e963c99c48c4b9045b4a04d173cb22 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/info.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/info.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44762/diff/
> 
> 
> Testing
> -------
> 
> The relations between classes in this proposal is:
> 
> ```
> +------------------------+
> |                        |
> | CgroupsIsolatorProcess <---------------------+
> |                        |                     |
> +------------^-----------+                     +
>              |                           Belongs to
>              +                                 +
>         Belongs to                             |
>              +                                 |
>              |                                 |
>        +-----+-----+               +-----------+---------+
>        |           |               |                     |
>        | Subsystem <---+Used by+---+ CgroupsIsolatorInfo |
>        |           |               |                     |
>        +-----------+               +---------------------+
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message