mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shuai Lin <linshuai2...@gmail.com>
Subject Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.
Date Tue, 21 Jun 2016 12:05:27 GMT


> On June 20, 2016, 5:36 p.m., haosdent huang wrote:
> > src/tests/api_tests.cpp, line 765
> > <https://reviews.apache.org/r/48938/diff/1/?file=1423763#file1423763line765>
> >
> >     Insert a blank line below, refer to https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md#empty-lines

Thanks for the tip.


- Shuai


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48938/#review138642
-----------------------------------------------------------


On June 20, 2016, 1:54 a.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48938/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5502
>     https://issues.apache.org/jira/browse/MESOS-5502
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test case `MasterAPITest.CreateAndDetroyVolumes`.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp 7ce62d92a87f4885d8c4faab542c49d5bfb251d3 
>   src/internal/evolve.cpp 67c550342c06acdfcd0ed5cbe860ad29e41e6846 
>   src/tests/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf 
> 
> Diff: https://reviews.apache.org/r/48938/diff/
> 
> 
> Testing
> -------
> 
> "make check" on ubuntu 14.04 64bit with gcc.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message