mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 48986: Updated a typo for GPU_RESOURCES.
Date Tue, 21 Jun 2016 14:14:37 GMT


> On 六月 21, 2016, 1:19 p.m., Alexander Rukletsov wrote:
> > Why do you think it is a typo?
> 
> Guangya Liu wrote:
>     I think that here we should "preventing non-GPU workloads from using precious GPU
resources", comments?
> 
> Alexander Rukletsov wrote:
>     But this is what the original comment says, no? If you think it is confusing, we
can re-phrase it altogether.

Sure, can you please show some comments here? I think that my only concern is here: in order
to avoid occupying a GPU agent and preventing `GPU` workloads from using precious GPU resources!


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48986/#review138826
-----------------------------------------------------------


On 六月 21, 2016, 12:47 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48986/
> -----------------------------------------------------------
> 
> (Updated 六月 21, 2016, 12:47 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5634
>     https://issues.apache.org/jira/browse/MESOS-5634
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated a typo for GPU_RESOURCES.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto e4bb313f9229f2101aa69acf82e367c01aeefb63 
>   include/mesos/v1/mesos.proto 8bba833c65c7f7b18fbdfe981280ef5d39f8c70b 
> 
> Diff: https://reviews.apache.org/r/48986/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message