mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 41658: Track the allocation candidates to bound the allocation queue.
Date Tue, 21 Jun 2016 15:25:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41658/#review138796
-----------------------------------------------------------



We recently ran some benchmark and found this is helping with performance so we'd like to
revive and publish the benchmark.


src/master/allocator/mesos/hierarchical.hpp (line 365)
<https://reviews.apache.org/r/41658/#comment203992>

    Instead of using a counter I think the following is equivalent but simpler:
    
    ```
    bool allocationPending;
    ```
    
    So instead of always dispatching into the queue which results in many noops, we don't
dispatch if we know there is already an allocation pending in the queue. We merely update
`allocationCandidates`.
    
    Later after the allocation is run we reset the bool.
    
    Make sense?



src/master/allocator/mesos/hierarchical.cpp (lines 262 - 264)
<https://reviews.apache.org/r/41658/#comment203993>

    Here and elsehere
    
    ```
    allocationCandidates = slaves.keys(); 
    
    // or
    
    allocationCandidates.insert(slaveId);
    
    // then
    
    if (!allocationPending) {
      allocationPending = true;
      dispatch(self(), &Self::allocate);
    }
    ```



src/master/allocator/mesos/hierarchical.cpp (line 1080)
<https://reviews.apache.org/r/41658/#comment203994>

    This uses `true` but I don't see why batch needs to be different.



src/master/allocator/mesos/hierarchical.cpp (lines 1106 - 1107)
<https://reviews.apache.org/r/41658/#comment203996>

    After the allocation is done, 
    
    ```
    allocationPending = false;
    allocationCandidates.clear();
    ```



src/master/allocator/mesos/hierarchical.cpp (line 1116)
<https://reviews.apache.org/r/41658/#comment203995>

    No need to rename the method?


- Jiang Yan Xu


On Dec. 22, 2015, 11:56 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41658/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 11:56 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Klaus Ma.
> 
> 
> Bugs: MESOS-3157
>     https://issues.apache.org/jira/browse/MESOS-3157
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When there is churn in the cluster, frequent resource allocation
> is required.  Maintain a set of allocation candidates so that we
> don't end up running the same allocation multiple times.
> 
> This review is just for feedback. Not proposing it to be berged at this time.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08

>   src/master/allocator/mesos/hierarchical.cpp 775182515dcb52bd873ecdf98c827320251a59c8

> 
> Diff: https://reviews.apache.org/r/41658/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message