mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 49038: Fixed store.cpp break.
Date Tue, 21 Jun 2016 19:30:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49038/#review138917
-----------------------------------------------------------




src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 97)
<https://reviews.apache.org/r/49038/#comment204108>

    Can you add some comments about why the idndef here? It's not clear from the code:
    ```
    // NOTE: Docker fetcher is not supported on Windows.
    ```


- Jie Yu


On June 21, 2016, 7:19 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49038/
> -----------------------------------------------------------
> 
> (Updated June 21, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed store.cpp break.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp a4fccb31cbbd5638eb9341b346dccf191ef4b1b8

> 
> Diff: https://reviews.apache.org/r/49038/diff/
> 
> 
> Testing
> -------
> 
> Windows: build
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message