mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 48986: Updated a typo for GPU_RESOURCES.
Date Tue, 21 Jun 2016 20:22:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48986/#review138925
-----------------------------------------------------------




include/mesos/mesos.proto (line 281)
<https://reviews.apache.org/r/48986/#comment204117>

    We don't want to occupy a GPU agent and prevent GPU workloads from running, this adjustments
looks incorrect?
    
    How about:
    
    ```
          // Frameworks that are aware of GPU resources are expected to
          // avoid placing non-GPU workloads on GPU agents, in order to
          // avoid occupying a GPU agent and preventing GPU workloads
          // from running! Currently, if a ...
    ```


- Benjamin Mahler


On June 21, 2016, 2:14 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48986/
> -----------------------------------------------------------
> 
> (Updated June 21, 2016, 2:14 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5634
>     https://issues.apache.org/jira/browse/MESOS-5634
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated a typo for GPU_RESOURCES.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto e4bb313f9229f2101aa69acf82e367c01aeefb63 
>   include/mesos/v1/mesos.proto 8bba833c65c7f7b18fbdfe981280ef5d39f8c70b 
> 
> Diff: https://reviews.apache.org/r/48986/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message