mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 48910: Highlight disconnected frameworks in webui.
Date Tue, 21 Jun 2016 21:32:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48910/#review138945
-----------------------------------------------------------



Very nice, however the meaning of the color doesn't seem discoverable. Do we also need a legend
or an explicit field to indicate the state?

- Benjamin Mahler


On June 18, 2016, 7:16 p.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48910/
> -----------------------------------------------------------
> 
> (Updated June 18, 2016, 7:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Deshna Jain, haosdent huang, Ross Allen, and
Vinod Kone.
> 
> 
> Bugs: MESOS-2145
>     https://issues.apache.org/jira/browse/MESOS-2145
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When framework is active but no alive, it's row
> become highlighted with reddish background.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/frameworks.html cfb6f4efc259419e4cb697332c8d6f2839e96970 
> 
> Diff: https://reviews.apache.org/r/48910/diff/
> 
> 
> Testing
> -------
> 
> ![screenshot](https://issues.apache.org/jira/secure/attachment/12811674/frameworks_alive.png)
> 
> Run framework (e.g. Marathon) wait until it appear on `#/frameworks`. Stop it (no graceful
shutdown with deregistration). It should be highlighted with next page update.
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message