mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 48911: Show orphan tasks in WebUI.
Date Tue, 21 Jun 2016 21:39:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48911/#review138946
-----------------------------------------------------------


Fix it, then Ship it!




Looks good, thank you!

Can you please pull out the finish_time bug fix? In particular, we have to check if the last
status is terminal in order to set the terminal time. (We should do a `s/finish_time/terminal_time/`).

I'll go ahead and commit this without touching the finish_time, can you follow up with the
fix?


src/webui/master/static/js/controllers.js (lines 151 - 154)
<https://reviews.apache.org/r/48911/#comment204140>

    This still looks incorrect, we need to set the stopped time only if the last state is
terminal. Can you add an isTerminal helper and use that here to check the last state?
    
    Please pull this fix into a patch separate from this one.


- Benjamin Mahler


On June 18, 2016, 8:22 p.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48911/
> -----------------------------------------------------------
> 
> (Updated June 18, 2016, 8:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, haosdent huang, Ross Allen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added orphan tasks count on left side table.
> Added orphan tasks table under completed tasks.
> Fixed setting tasks.finish_time, if task is running
> this value won't be set.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/home.html a8c8c20ce7659eecd621fcf7714fac9274155d67 
>   src/webui/master/static/js/controllers.js fcb6242003326ab608aa72e6b881f8dbb9822b94

> 
> Diff: https://reviews.apache.org/r/48911/diff/
> 
> 
> Testing
> -------
> 
> ![orphan task](https://issues.apache.org/jira/secure/attachment/12811676/orphan_tasks.png)
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message