mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Review Request 49083: Remove lambda capture inconsistencies.
Date Wed, 22 Jun 2016 12:42:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49083/
-----------------------------------------------------------

Review request for mesos, Joerg Schad and Till Toenshoff.


Repository: mesos


Description
-------

Some elements of similar types (Owned pointers to other objects)
where capture as references while others were captured as value
in the same lambda.

Note that capturing by reference could be potentially dangerous
in asynchronous situations (which this was not) by causing dangling
pointer errors.

However, pointer objects are easy and small to copy that capturing
by value in these cases is preferable.


Diffs
-----

  src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e 

Diff: https://reviews.apache.org/r/49083/diff/


Testing
-------

`make check`


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message