mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 49064: Implement v1 operator update weights API.
Date Wed, 22 Jun 2016 14:35:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49064/#review139065
-----------------------------------------------------------




src/master/master.hpp (lines 1113 - 1115)
<https://reviews.apache.org/r/49064/#comment204222>

    Indent incorrect here. Only need 4 spaces.



src/master/weights_handler.cpp (line 192)
<https://reviews.apache.org/r/49064/#comment204224>

    Suggest to add a check like
    ```
    CHECK(call.update_weights().has_weight_infos());
    ```



src/master/weights_handler.cpp (line 193)
<https://reviews.apache.org/r/49064/#comment204223>

    We need update the validation.cpp as well.
    
    ```
        case mesos::master::Call::UPDATE_WEIGHTS:
          return None();
    
    ```


- haosdent huang


On June 22, 2016, 5:21 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49064/
> -----------------------------------------------------------
> 
> (Updated June 22, 2016, 5:21 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5496
>     https://issues.apache.org/jira/browse/mesos-5496
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented updateWeights method in WeightsHandler.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 
>   include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 
>   src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e 
>   src/master/master.hpp fe57878dc59637459d5c5cdae0be2aa159133fa4 
>   src/master/weights_handler.cpp 51c957f9ad278e60541b2bde3de2b6090a541ec4 
>   src/tests/api_tests.cpp bf1a294f1fc3c8659c31115beee3876d4d0a45e2 
> 
> Diff: https://reviews.apache.org/r/49064/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message