mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 48994: Fixed portmapping isolator bind mount root non-existed case.
Date Wed, 22 Jun 2016 18:19:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48994/#review139103
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/network/port_mapping.cpp (line 1894)
<https://reviews.apache.org/r/48994/#comment204248>

    Hum, just realized an issue. If you do that, bindMountRoot is no longer guaranteed to
be realpath, right? Can you just move mdkir to the top?


- Jie Yu


On June 21, 2016, 2:46 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48994/
> -----------------------------------------------------------
> 
> (Updated June 21, 2016, 2:46 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Artem Harutyunyan, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-5673
>     https://issues.apache.org/jira/browse/MESOS-5673
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed portmapping isolator bind mount root non-existed case.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 5df591893f3015926a7cfe07e9b57749c46f6367

> 
> Diff: https://reviews.apache.org/r/48994/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message