mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 48902: Move v1/master/allocator.proto to its own package.
Date Wed, 22 Jun 2016 18:20:54 GMT


> On June 21, 2016, 12:36 a.m., Vinod Kone wrote:
> > src/CMakeLists.txt, line 24
> > <https://reviews.apache.org/r/48902/diff/1/?file=1423303#file1423303line24>
> >
> >     don't you need to change this?

I'd like to address this in a separate patch, and I have some open question on how to handle
`mesos::master::allocator::Allocator` class and its namespace. See my last question in MESOS-5642.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48902/#review138709
-----------------------------------------------------------


On June 22, 2016, 6:19 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48902/
> -----------------------------------------------------------
> 
> (Updated June 22, 2016, 6:19 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joris Van Remoortere, Joseph Wu, and Vinod
Kone.
> 
> 
> Bugs: MESOS-5642
>     https://issues.apache.org/jira/browse/MESOS-5642
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Move v1/master/allocator.proto to its own package.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/maintenance/maintenance.proto 053d72d7d9fa9ec8f572136020546fa4f955ab09

>   include/mesos/v1/master/allocator.proto cf416d173bc487aecbbec75c9ee391a54bf5327b 
>   src/CMakeLists.txt d66186217c1319d4497640614ed4beee28602c38 
>   src/Makefile.am 23cac95a805e46d216e9479fea09f2c1619c45a5 
> 
> Diff: https://reviews.apache.org/r/48902/diff/
> 
> 
> Testing
> -------
> 
> run `make` on Mac.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message