mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 48994: Fixed portmapping isolator bind mount root non-existed case.
Date Wed, 22 Jun 2016 20:50:13 GMT


> On June 22, 2016, 11:19 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 1894
> > <https://reviews.apache.org/r/48994/diff/1/?file=1425967#file1425967line1894>
> >
> >     Hum, just realized an issue. If you do that, bindMountRoot is no longer guaranteed
to be realpath, right? Can you just move mdkir to the top?

I dont see why it is no longer a realpath. Currently `PORT_MAPPING_BIND_MOUNT_ROOT()` is hard
coded as `/var/run/netns`. If it does not exist, we mkdir. the newly created dir should be
a realpath as well. 

But yes, moving mkdir above should be a cleaner solution and make more sense.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48994/#review139103
-----------------------------------------------------------


On June 20, 2016, 7:46 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48994/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 7:46 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Artem Harutyunyan, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-5673
>     https://issues.apache.org/jira/browse/MESOS-5673
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed portmapping isolator bind mount root non-existed case.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 5df591893f3015926a7cfe07e9b57749c46f6367

> 
> Diff: https://reviews.apache.org/r/48994/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message