mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 48995: Fixed portmapping isolator symlink existed failure.
Date Wed, 22 Jun 2016 21:15:50 GMT


> On June 22, 2016, 11:03 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 2587
> > <https://reviews.apache.org/r/48995/diff/1/?file=1425968#file1425968line2587>
> >
> >     Instead of doing that, can you use a uuid for container id in the corresponding
test?
> 
> Gilbert Song wrote:
>     My bad, should have realize that:(

I fixed them all together in port mapping tests.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48995/#review139098
-----------------------------------------------------------


On June 20, 2016, 7:46 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48995/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 7:46 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Artem Harutyunyan, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-5674
>     https://issues.apache.org/jira/browse/MESOS-5674
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed portmapping isolator symlink existed failure.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 5df591893f3015926a7cfe07e9b57749c46f6367

> 
> Diff: https://reviews.apache.org/r/48995/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message