mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 47972: Updated rmdir to continue deletion on error.
Date Wed, 22 Jun 2016 21:31:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47972/#review139144
-----------------------------------------------------------



flying by


3rdparty/stout/include/stout/os/windows/rmdir.hpp (lines 102 - 103)
<https://reviews.apache.org/r/47972/#comment204288>

    indentation here should be 4


- Jie Yu


On June 19, 2016, 3:50 a.m., Megha Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47972/
> -----------------------------------------------------------
> 
> (Updated June 19, 2016, 3:50 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Jiang Yan
Xu.
> 
> 
> Bugs: MESOS-5196
>     https://issues.apache.org/jira/browse/MESOS-5196
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updates made to rmdir to prevent early exit in the event of error.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/posix/rmdir.hpp 4780a13465ee1323c49db9911bc7083173cfe0df

>   3rdparty/stout/include/stout/os/windows/rmdir.hpp 772b86dd111d28aefbeeba5f829ffa377fd12efb

>   3rdparty/stout/tests/os/rmdir_tests.cpp a11bfc9f9e6cbb05f3e9ce0ea48297b8f88fe53f 
> 
> Diff: https://reviews.apache.org/r/47972/diff/
> 
> 
> Testing
> -------
> 
> testing done with 'make check'.
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message