mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 49013: Updated cgroups/devices isolator's prepare() to directly return None().
Date Wed, 22 Jun 2016 21:56:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49013/#review139149
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On June 22, 2016, 9:51 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49013/
> -----------------------------------------------------------
> 
> (Updated June 22, 2016, 9:51 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-5582
>     https://issues.apache.org/jira/browse/MESOS-5582
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated cgroups/devices isolator's prepare() to directly return None().
> 
> cgroups/devices isolator does not implement its own update() method,
> so in its prepare(), we do not need to call update(), instead we should
> directly return None() in the end.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/devices.cpp 16f962894e89317a436a0e38465338f42bfb83ef

> 
> Diff: https://reviews.apache.org/r/49013/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message