mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 49070: Used checkpointed CNI network config during cleanup.
Date Wed, 22 Jun 2016 22:01:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49070/#review139153
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 1274)
<https://reviews.apache.org/r/49070/#comment204304>

    Can we add a VLOG here similar to what we did in `attach`?


- Jie Yu


On June 22, 2016, 8:33 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49070/
> -----------------------------------------------------------
> 
> (Updated June 22, 2016, 8:33 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5310
>     https://issues.apache.org/jira/browse/MESOS-5310
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used checkpointed CNI network config during cleanup.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 8cf5fcb1e63873b2a3eca843130a361f25a6e825

> 
> Diff: https://reviews.apache.org/r/49070/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message