mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 48989: Fixed broken cni isolator test on centos7.
Date Thu, 23 Jun 2016 00:17:10 GMT


> On June 22, 2016, 10:20 a.m., Qian Zhang wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp, line 185
> > <https://reviews.apache.org/r/48989/diff/1/?file=1425962#file1425962line185>
> >
> >     I just manually ran a Docker container from 'alpine' image in an RHEL 7.1 machine,
and `/bin/sh -c 'ifconfig'` can work successfully. I thought there should be no much difference
between RHEL and CentOS, so not sure why it does not work in CentOS ...
> 
> Jie Yu wrote:
>     Qian, i think it depends on your shell.
> 
> Gilbert Song wrote:
>     Yeah, it really depends on os default PATH. The test would fail or not on diff CentOS
7.x. We encountered similar issues a couple times.

Got it, thanks Jie and Gilbert!


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48989/#review139009
-----------------------------------------------------------


On June 23, 2016, 6:54 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48989/
> -----------------------------------------------------------
> 
> (Updated June 23, 2016, 6:54 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Guangya Liu, Artem Harutyunyan, Jie Yu,
and Qian Zhang.
> 
> 
> Bugs: MESOS-5667
>     https://issues.apache.org/jira/browse/MESOS-5667
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed broken cni isolator test on centos7.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cni_isolator_tests.cpp a51f24b0c4946ffe464e55ca1f25a1a38090e094

> 
> Diff: https://reviews.apache.org/r/48989/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message