mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 49095: Enabled fine-grained authorization in the master's frameworks endpoint.
Date Thu, 23 Jun 2016 00:35:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49095/#review139191
-----------------------------------------------------------



Patch looks great!

Reviews applied: [49095]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On June 22, 2016, 3:59 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49095/
> -----------------------------------------------------------
> 
> (Updated June 22, 2016, 3:59 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Even if ACLs were defined for the actions `VIEW_FRAMEWORKS`,
> `VIEW_EXECUTORS` and `VIEW_TASKS`, the data these actions were
> supposed to protect, could still leaked through the master's
> `/frameworks` endpoint, since it didn't enable any authorization
> mechanism.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e 
>   src/tests/master_authorization_tests.cpp 9ae6b9dc89538716d397ffd8826187e2bc6d7e8f 
> 
> Diff: https://reviews.apache.org/r/49095/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message