mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 49122: Added a MAC parse function to stout.
Date Thu, 23 Jun 2016 01:37:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49122/#review139197
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


3rdparty/stout/include/stout/mac.hpp (line 85)
<https://reviews.apache.org/r/49122/#comment204342>

    s/digits/digit


- Avinash sridharan


On June 22, 2016, 11:56 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49122/
> -----------------------------------------------------------
> 
> (Updated June 22, 2016, 11:56 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a MAC parse function to stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/mac.hpp 1aaafe1380c5300225c2ac9276e87962bd5a0d88 
>   3rdparty/stout/tests/mac_tests.cpp f905d4528040ce97d80010b2ba3f13870dca0c7c 
> 
> Diff: https://reviews.apache.org/r/49122/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message