mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49184: Implemented file volume support in mesos containerizer.
Date Fri, 24 Jun 2016 08:11:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49184/#review139358
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (lines 404 - 420)
<https://reviews.apache.org/r/49184/#comment204532>

    Can you please add some comments here for why not handling the case for absolute path
case with containers which does not have rootfs?
    
    I think that the file volume was already supported by containers without rootfs if the
container path is an absolute path in Line429-437?



src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (lines 469 - 472)
<https://reviews.apache.org/r/49184/#comment204547>

    What about
    
    return Error(
        "Failed to create the target mount file directory at '" +
        Path(mountPoint).dirname() + "': " + mkdir.error());


- Guangya Liu


On 六月 24, 2016, 6:28 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49184/
> -----------------------------------------------------------
> 
> (Updated 六月 24, 2016, 6:28 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Timothy Chen, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5697
>     https://issues.apache.org/jira/browse/MESOS-5697
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented file volume support in mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp adacde191132a7a92c1fdf27ef8a4a41d2afa003

> 
> Diff: https://reviews.apache.org/r/49184/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message