mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49214: Added `FileInfo` protobuf for describing a File.
Date Fri, 24 Jun 2016 20:49:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49214/#review139400
-----------------------------------------------------------




include/mesos/mesos.proto (lines 2038 - 2054)
<https://reviews.apache.org/r/49214/#comment204616>

    are all these available on all tye OSses we support? OSX, Windows and Linux? If not, some
of these might have to be optional.



include/mesos/mesos.proto (line 2047)
<https://reviews.apache.org/r/49214/#comment204615>

    s/can be moved around systems portably/is portable/.


- Vinod Kone


On June 24, 2016, 7:52 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49214/
> -----------------------------------------------------------
> 
> (Updated June 24, 2016, 7:52 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, zhou xing, and Vinod Kone.
> 
> 
> Bugs: MESOS-5514
>     https://issues.apache.org/jira/browse/MESOS-5514
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change would be needed later for implementing the `LIST_FILES`
> call for the Master/Agent v1 API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8a417f91ca6771b971cf5ee50351171412163f7a 
>   include/mesos/v1/mesos.proto 3bc65e7fb1b34651bf025711023f9e219928040a 
> 
> Diff: https://reviews.apache.org/r/49214/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message