mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48841: Add Agent protobuf message.
Date Fri, 24 Jun 2016 22:26:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48841/#review139413
-----------------------------------------------------------




include/mesos/master/master.proto (lines 284 - 290)
<https://reviews.apache.org/r/48841/#comment204641>

    agree with zhitao here. lets re-use AgentInfo here and add extra information.



include/mesos/master/master.proto (line 295)
<https://reviews.apache.org/r/48841/#comment204640>

    new line to make it clear that the comment applies only to `total_resources`.


- Vinod Kone


On June 23, 2016, 5:13 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48841/
> -----------------------------------------------------------
> 
> (Updated June 23, 2016, 5:13 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5491
>     https://issues.apache.org/jira/browse/mesos-5491
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch added Agent protobuf message to:
> 1. v1 message: v1/master/master.proto
> 2. unversioned message: master/master.proto
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 
>   include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 
> 
> Diff: https://reviews.apache.org/r/48841/diff/
> 
> 
> Testing
> -------
> 
> make 
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message